Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ade7913 driver improvements #510

Merged
merged 4 commits into from
Aug 2, 2024
Merged

ade7913 driver improvements #510

merged 4 commits into from
Aug 2, 2024

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Aug 2, 2024

  • fix support for 3x ADE invocation
  • fix EDMA per-channel functions

Description

NIL v33

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@nalajcie
edma: fix per-channel functions
55dacee 
Previous implementation `edma_channel_enable` would enable all channels
instead of only the desired one.

JIRA: NIL-584
@nalajcie
ade7913: add descriptions of DMA internal workings
2540b1a 
JIRA: NIL-584
agkaminski
agkaminski reviewed Aug 2, 2024
View reviewed changes
adc/ade7913/ade7913.c Show resolved Hide resolved
adc/ade7913/ade7913-driver.c Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   39m 16s ⏱️ + 1m 25s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit a40b672. ± Comparison against base commit 4d8edcc.

@nalajcie nalajcie merged commit 6497d27 into master Aug 2, 2024
30 checks passed
@nalajcie nalajcie deleted the nalajcie/ade branch August 2, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@agkaminski agkaminski agkaminski approved these changes

@ziemleszcz ziemleszcz Awaiting requested review from ziemleszcz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalajcie @agkaminski